Bug 143592

Summary:

Pull emoji-position adjustment code into its own function

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fred.wang, mmaxfield, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mmaxfield: review+

Description Simon Fraser (smfr) 2015-04-09 18:14:06 PDT

Pull emoji-position adjustment code into its own function

Comment 1 Simon Fraser (smfr) 2015-04-09 18:14:53 PDT

Created attachment 250493 [details]
Patch

Comment 2 Myles C. Maxfield 2015-04-09 18:18:40 PDT

Comment on attachment 250493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250493&action=review

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:210
> +    if (platformData.m_isEmoji) {

Early return

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:228
> +                y -= .35f * fontSize - 10;

Magic numbers :(

Comment 3 Simon Fraser (smfr) 2015-04-16 11:49:28 PDT

https://trac.webkit.org/r182898