Bug 143571

Summary: [Mac] Refactor MediaPlaybackTarget
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Updated patch.
jer.noble: review+
Patch for the bots. none

Description Eric Carlson 2015-04-09 12:40:19 PDT 
MediaPlaybackTarget should be refcounted.
Comment 1 Eric Carlson 2015-04-09 14:41:40 PDT 
Created attachment 250468 [details]
Proposed patch.
Comment 2 Eric Carlson 2015-04-09 14:51:17 PDT 
Created attachment 250470 [details]
Updated patch.
Comment 3 WebKit Commit Bot 2015-04-09 14:53:57 PDT 
Attachment 250470 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetContextMac.mm:58:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetContextMac.mm:58:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Jer Noble 2015-04-09 15:51:33 PDT 
Comment on attachment 250470 [details]
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=250470&action=review

r=me with nit:

> Source/WebCore/platform/graphics/MediaPlaybackTargetContext.h:45
> +#if PLATFORM(COCOA)
> +    WEBCORE_EXPORT void encode(NSKeyedArchiver *) const;
> +    WEBCORE_EXPORT static bool decode(NSKeyedUnarchiver *, MediaPlaybackTargetContext&);
> +#endif

nit: Maybe move these into WebCoreArgumentCodersMac.mm?
Comment 5 Eric Carlson 2015-04-09 18:05:49 PDT 
Created attachment 250490 [details]
Patch for the bots.
Comment 6 WebKit Commit Bot 2015-04-09 18:07:58 PDT 
Attachment 250490 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:486:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:486:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Eric Carlson 2015-04-10 07:33:43 PDT 
(In reply to comment #4)
> Comment on attachment 250470 [details]
> Updated patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250470&action=review
> 
> r=me with nit:
> 
> > Source/WebCore/platform/graphics/MediaPlaybackTargetContext.h:45
> > +#if PLATFORM(COCOA)
> > +    WEBCORE_EXPORT void encode(NSKeyedArchiver *) const;
> > +    WEBCORE_EXPORT static bool decode(NSKeyedUnarchiver *, MediaPlaybackTargetContext&);
> > +#endif
> 
> nit: Maybe move these into WebCoreArgumentCodersMac.mm?

Good idea, done.
Comment 8 Eric Carlson 2015-04-10 07:34:07 PDT 
Committed r182630: https://trac.webkit.org/r182630