Bug 143553

Summary:

run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Tools / Tests

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, rniwa, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none

Description Filip Pizlo 2015-04-08 20:44:19 PDT

Since removing the overall arithmetic/geometric/harmonic averages, we print the VM header twice, like:

                                                        TipOfTree              FunctionRealloc                                  

                                                        TipOfTree              FunctionRealloc                                  
Geomean of preferred means:
   <scaled-result>                                   64.0958+-0.1805           63.8925+-0.1926          might be 1.0032x faster

We only need to print it once.

Comment 1 Filip Pizlo 2015-04-08 20:45:39 PDT

Created attachment 250408 [details]
the patch

Comment 2 WebKit Commit Bot 2015-04-08 21:48:20 PDT

Comment on attachment 250408 [details]
the patch

Clearing flags on attachment: 250408

Committed r182586: <http://trac.webkit.org/changeset/182586>

Comment 3 WebKit Commit Bot 2015-04-08 21:48:25 PDT

All reviewed patches have been landed.  Closing bug.