Bug 143543

Summary: [Win] Layout Test fast/backgrounds/selection-background-color-of-list-style.html is failing
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Layout and RenderingAssignee: ChangSeok Oh <changseok>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2015-04-08 17:27:15 PDT
The following layout test is failing on Windows fast/backgrounds/selection-background-color-of-list-style.html fast/backgrounds/selection-background-color-of-image-list-style.html
Attachments
Patch (28.56 KB, patch)
2015-04-08 23:30 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-04-08 17:28:20 PDT
This may just need a rebaseline.
Brent Fulgham
Comment 2 2015-04-08 17:33:25 PDT
Tests marked as failing in r182575 <https://trac.webkit.org/changeset/182575>.
ChangSeok Oh
Comment 3 2015-04-08 20:42:39 PDT
(In reply to comment #2) > Tests marked as failing in r182575 > <https://trac.webkit.org/changeset/182575>. Oh. sorry, I didn't notice that. thank you!
ChangSeok Oh
Comment 4 2015-04-08 20:45:11 PDT
By the way, I have no windows machine so that I can't do rebaseline on my side. :P
Brent Fulgham
Comment 5 2015-04-08 20:47:06 PDT
(In reply to comment #4) > By the way, I have no windows machine so that I can't do rebaseline on my > side. :P You can get the results from the failing tests shown on the bots. You should try to grab them soon, as they will be lost in a day or two: https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r182573%20(50959)/results.html
ChangSeok Oh
Comment 6 2015-04-08 20:52:29 PDT
(In reply to comment #5) > (In reply to comment #4) > > By the way, I have no windows machine so that I can't do rebaseline on my > > side. :P > > You can get the results from the failing tests shown on the bots. You should > try to grab them soon, as they will be lost in a day or two: > > https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/ > r182573%20(50959)/results.html Aha. then I can do it. =)
ChangSeok Oh
Comment 7 2015-04-08 23:30:26 PDT
Created attachment 250420 [details] Patch
ChangSeok Oh
Comment 8 2015-04-10 02:28:31 PDT
Is it ok that I just land this?
Brent Fulgham
Comment 9 2015-04-10 09:12:14 PDT
Comment on attachment 250420 [details] Patch r=me. Thank you for updating these test expectations!
WebKit Commit Bot
Comment 10 2015-04-10 11:15:50 PDT
Comment on attachment 250420 [details] Patch Clearing flags on attachment: 250420 Committed r182635: <http://trac.webkit.org/changeset/182635>
WebKit Commit Bot
Comment 11 2015-04-10 11:15:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.