Bug 143514

Summary: [EFL] Create PageUIClientEfl after sending CreateWebPage message
Product: WebKit Reporter: Jaehun Lim <ljaehun.lim>
Component: WebKit EFLAssignee: Jaehun Lim <ljaehun.lim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jaehun Lim
Reported 2015-04-07 22:49:24 PDT
UIProcess sends some messages to WebPage before WebPage is created. It makes some error logs on debug build. Error Log: ERROR: Unhandled web process message 'WebPage:SetCanRunBeforeUnloadConfirmPanel' ../../Source/WebKit2/WebProcess/WebProcess.cpp(643) : virtual void WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) ERROR: Unhandled web process message 'WebPage:SetCanRunModal' ../../Source/WebKit2/WebProcess/WebProcess.cpp(643) : virtual void WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) So this patch moves the initialization of m_pageUIClient after calling WKViewInitialize().
Attachments
Patch (2.57 KB, patch)
2015-04-07 22:53 PDT, Jaehun Lim 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2015-04-08 21:21 PDT, Jaehun Lim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jaehun Lim
Comment 1 2015-04-07 22:53:49 PDT
Created attachment 250335 [details] Patch
Gyuyoung Kim
Comment 2 2015-04-08 21:16:46 PDT
Comment on attachment 250335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250335&action=review Thanks, LGTM. > Source/WebKit2/ChangeLog:11 > + Error Log: BTW, it looks this error log is not necessary in ChangeLog.
Jaehun Lim
Comment 3 2015-04-08 21:21:01 PDT
Created attachment 250414 [details] Patch
Jaehun Lim
Comment 4 2015-04-08 21:22:25 PDT
Comment on attachment 250335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250335&action=review >> Source/WebKit2/ChangeLog:11 >> + Error Log: > > BTW, it looks this error log is not necessary in ChangeLog. Thanks. I removed.
WebKit Commit Bot
Comment 5 2015-04-08 22:22:17 PDT
The commit-queue encountered the following flaky tests while processing attachment 250414 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) fast/events/media-focus-in-standalone-media-document.html bug 143555 The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2015-04-08 22:23:45 PDT
Comment on attachment 250414 [details] Patch Clearing flags on attachment: 250414 Committed r182588: <http://trac.webkit.org/changeset/182588>
WebKit Commit Bot
Comment 7 2015-04-08 22:23:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.