Summary: | Add experimental code to use custom font dilation when rendering into non-opaque contexts | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, jonlee, mmaxfield, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2015-04-07 19:23:33 PDT
Created attachment 250324 [details]
Patch
Attachment 250324 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:83: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5]
Total errors found: 9 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 250324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250324&action=review > Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:207 > +static CGSize dilationSizeForTextColor(const Color& color) Can you add a comment explaining these numbers Looks like this broke iOS: /Volumes/Data/EWS/WebKit/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:82:5: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef] #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 ^ /Volumes/Data/EWS/WebKit/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:132:5: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef] #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 I believe __MAC_OS_X_VERSION_MIN_REQUIRED is only defined #if PLATFORM(MAC). (In reply to comment #5) > Looks like this broke iOS: > /Volumes/Data/EWS/WebKit/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:82: > 5: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 > [-Werror,-Wundef] > #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 > ^ > /Volumes/Data/EWS/WebKit/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h: > 132:5: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to > 0 [-Werror,-Wundef] > #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 > > I believe __MAC_OS_X_VERSION_MIN_REQUIRED is only defined #if PLATFORM(MAC). Speculative iOS build fix landed in <http://trac.webkit.org/changeset/182519>. Thanks Chris. |