| Summary: | Fill list style background with same color with that of list background. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | ChangSeok Oh <changseok> | ||||||||||||||
| Component: | CSS | Assignee: | ChangSeok Oh <changseok> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | buildbot, changseok, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield, rniwa, simon.fraser, zalan | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
ChangSeok Oh
2015-04-07 10:16:22 PDT
Created attachment 250273 [details]
Patch
WIP
Created attachment 250341 [details]
Patch
Comment on attachment 250341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250341&action=review > LayoutTests/ChangeLog:9 > + * fast/backgrounds/selection-background-color-of-image-list-style.html: Added. > + * fast/backgrounds/selection-background-color-of-list-style.html: Added. It would be good if these could be reference tests instead. > LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html:3 > +ul>li::selection { background: red; } Please don't use red in a passing test. Comment on attachment 250341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250341&action=review Thanks for your review. >> LayoutTests/ChangeLog:9 >> + * fast/backgrounds/selection-background-color-of-list-style.html: Added. > > It would be good if these could be reference tests instead. Hrm. I don't know a better way except pixel test. Is there a way to get background color of list style programmatically? >> LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html:3 >> +ul>li::selection { background: red; } > > Please don't use red in a passing test. Then green? Though I could write a reference test, but I can create a perfectly matched expected.html. Reference test is too strict. I can't overcome 0.01% of difference between expected and actual. Is there anyway to suppress it? (In reply to comment #5) > but I can create a perfectly matched expected.html. Sorry, %s/can/can't Created attachment 250349 [details]
Patch
Comment on attachment 250349 [details] Patch Attachment 250349 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6748241802559488 New failing tests: fast/backgrounds/selection-background-color-of-image-list-style.html fast/backgrounds/selection-background-color-of-list-style.html Created attachment 250350 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 250349 [details] Patch Attachment 250349 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5321318375358464 New failing tests: fast/backgrounds/selection-background-color-of-image-list-style.html fast/backgrounds/selection-background-color-of-list-style.html Created attachment 250351 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Weird. I don't know where the 0.01% difference come from. I'll bring back pixel test results and land it if no strong objection. Created attachment 250353 [details]
Patch
Comment on attachment 250353 [details] Patch Clearing flags on attachment: 250353 Committed r182546: <http://trac.webkit.org/changeset/182546> Patch landed. Close this. |