Bug 143449

Summary: Simplify ownership model of RefCounter::Count
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: Web Template FrameworkAssignee: Gavin Barraclough <barraclough>
Status: NEW    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix sam: review+

Gavin Barraclough
Reported 2015-04-06 11:52:17 PDT
Currently the count manipulated by ref/deref does not fully determine the lifetime of the object - the object is either kept alive if the refcount is non-zero, or if the owner RefCounter is still alive (separately determined). Make the object lifetime simpler by making it purely determined by the RefCount (and as such RefCounter::Count can just become a regular RefCounted). Add a new variable to track the counter value. This patch is a step towards adding a token type that doesn't increment the count (to be able to avoid bogus churn & keep the count accurate).
Attachments
Fix (7.75 KB, patch)
2015-04-06 12:01 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2015-04-06 12:01:14 PDT
Created attachment 250216 [details] Fix
Note You need to log in before you can comment on or make changes to this bug.