Bug 143446

Summary:

Use content extensions in MiniBrowser

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

Tools / Tests

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

143459

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	achristensen: review+

Description Alex Christensen 2015-04-06 11:12:46 PDT

This makes testing easier.  Sam wrote the patch, but I'm uploading it.

Comment 1 Alex Christensen 2015-04-06 11:20:03 PDT

Created attachment 250212 [details]
Patch

Comment 2 WebKit Commit Bot 2015-04-06 11:21:06 PDT

Attachment 250212 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/ExtensionManagerWindowController.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alex Christensen 2015-04-06 15:00:27 PDT

Created attachment 250229 [details]
Patch

Comment 4 WebKit Commit Bot 2015-04-06 15:02:58 PDT

Attachment 250229 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/ExtensionManagerWindowController.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Alex Christensen 2015-04-06 17:43:02 PDT

Created attachment 250247 [details]
Patch

Comment 6 WebKit Commit Bot 2015-04-06 17:44:44 PDT

Attachment 250247 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/ExtensionManagerWindowController.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Alex Christensen 2015-04-07 10:08:44 PDT

recommitted to http://trac.webkit.org/changeset/182476 after fixing 32-bit build