Bug 143444

Summary: Combine ActionMenuHitTestResult with WebHitTestResult
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 none

Brady Eidson
Reported 2015-04-06 10:50:03 PDT
Combine ActionMenuHitTestResult with WebHitTestResult It really doesn't need to be separate. For example, all of the additional info it stores can be (and will soon be) relevant for normal context menu operations.
Attachments
Patch v1 (60.17 KB, patch)
2015-04-06 11:11 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-04-06 11:11:15 PDT
Created attachment 250210 [details] Patch v1
WebKit Commit Bot
Comment 2 2015-04-06 11:13:52 PDT
Attachment 250210 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/mac/WebHitTestResult.mm:81: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/WebHitTestResult.mm:81: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2015-04-06 15:34:51 PDT
Comment on attachment 250210 [details] Patch v1 Clearing flags on attachment: 250210 Committed r182442: <http://trac.webkit.org/changeset/182442>
WebKit Commit Bot
Comment 4 2015-04-06 15:34:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.