Bug 143443 – [GTK] install-dependencies should install the right version of geoclue

• Component: WebKitGTK
• Status: RESOLVED INVALID

[Michael Catanzaro]

Our install-dependencies script is installing the wrong version of geoclue.

Note, Debian seems to have the .pc file for new geoclue in the main package rather than a -dev package, as far as I can tell. That seems like a bug...?

[Michael Catanzaro]

Created attachment 250204 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 250204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250204&action=review

> Tools/gtk/install-dependencies:61
> +        geoclue-2.0 \

Don't we need the -dev package? is 2.0 available in the bots?

[Martin Robinson]

(In reply to comment #0)
> Our install-dependencies script is installing the wrong version of geoclue.
> 
> Note, Debian seems to have the .pc file for new geoclue in the main package
> rather than a -dev package, as far as I can tell. That seems like a bug...?

I wouldn't say it is "wrong" since both versions of Geoclue are supported. I wonder if it's possible to do this without the entire script failing on older versions of Debian or Ubuntu though.

[Michael Catanzaro]

(In reply to comment #2)
> Don't we need the -dev package? 

See comment #0

> is 2.0 available in the bots?

I dunno; how do I check this? geoclue2 was a dependency of GNOME 3.10, so I presume you have it by now, but it looks like it was only added to Debian last summer, so it depends on how new the bots are. Do they run this script?

(In reply to comment #3)
> I wouldn't say it is "wrong" since both versions of Geoclue are supported.

Hm, for some reason I thought only the newer geoclue was supported. Then I guess we don't need this patch.

> I
> wonder if it's possible to do this without the entire script failing on
> older versions of Debian or Ubuntu though.

Hm... on Fedora it would cause the script to fail, but geoclue2 exists on F20, the oldest supported version, so it doesn't matter. I don't know if apt-get would fail or just ignore the missing package, but I would guess fail.

TBH, since old geoclue is supported, I'd say we can just close this bug.