Summary: | Remove CSS functions min() and max() which had been dropped from specification | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joonghun Park <jh718.park> | ||||
Component: | CSS | Assignee: | Joonghun Park <jh718.park> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, gyuyoung.kim, ossy, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joonghun Park
2015-04-06 04:50:58 PDT
Created attachment 250200 [details]
Patch
Comment on attachment 250200 [details]
Patch
I don’t understand this patch. Is there a behavior change? Was this really the only code we had? No test covering it?
(In reply to comment #2) > Comment on attachment 250200 [details] > Patch > > I don’t understand this patch. Is there a behavior change? Was this really > the only code we had? No test covering it? Yes, I think that's all of the calculation min() and max() related codes we have currently. If we choose to implement min() and max() functions which defined in http://www.w3.org/TR/2011/WD-css3-values-20110906/#calc it would needs patch like https://bugs.webkit.org/show_bug.cgi?id=143515, then LayoutTests/css3/calc/simple-minmax-expected.txt can be turned to pass result, but the latest specification of CSS Values and Units Module Level3 dropped those functions so I think the implementation of those are not needed anymore. :) Comment on attachment 250200 [details] Patch Clearing flags on attachment: 250200 Committed r182525: <http://trac.webkit.org/changeset/182525> All reviewed patches have been landed. Closing bug. |