Bug 143440

Summary: Remove CSS functions min() and max() which had been dropped from specification
Product: WebKit Reporter: Joonghun Park <jh718.park>
Component: CSSAssignee: Joonghun Park <jh718.park>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, gyuyoung.kim, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Joonghun Park 2015-04-06 04:50:58 PDT
In the latest specification of CSS Values and Units Module Level3(http://www.w3.org/TR/css3-values/) min() and max() function had been dropped already during the CR period.
So remove these css functions which not conform with the current specification.
Comment 1 Joonghun Park 2015-04-06 04:54:19 PDT
Created attachment 250200 [details]
Patch
Comment 2 Darin Adler 2015-04-06 09:07:48 PDT
Comment on attachment 250200 [details]
Patch

I don’t understand this patch. Is there a behavior change? Was this really the only code we had? No test covering it?
Comment 3 Joonghun Park 2015-04-07 23:39:47 PDT
(In reply to comment #2)
> Comment on attachment 250200 [details]
> Patch
> 
> I don’t understand this patch. Is there a behavior change? Was this really
> the only code we had? No test covering it?

Yes, I think that's all of the calculation min() and max() related codes
we have currently.

If we choose to implement min() and max() functions 
which defined in http://www.w3.org/TR/2011/WD-css3-values-20110906/#calc
it would needs patch like https://bugs.webkit.org/show_bug.cgi?id=143515,
then LayoutTests/css3/calc/simple-minmax-expected.txt can be turned to pass result, but the latest specification of CSS Values and Units Module Level3 dropped those functions so I think the implementation of those are not needed anymore. :)
Comment 4 WebKit Commit Bot 2015-04-08 00:45:46 PDT
Comment on attachment 250200 [details]
Patch

Clearing flags on attachment: 250200

Committed r182525: <http://trac.webkit.org/changeset/182525>
Comment 5 WebKit Commit Bot 2015-04-08 00:45:51 PDT
All reviewed patches have been landed.  Closing bug.