Summary: | [ES6] DFG and FTL should be aware of that StringConstructor behavior for symbols becomes different from ToString | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, joepeck | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 141279 | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2015-04-05 14:49:45 PDT
Created attachment 250171 [details]
Patch
*** Bug 143427 has been marked as a duplicate of this bug. *** Comment on attachment 250171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250171&action=review > Source/JavaScriptCore/runtime/StringConstructor.cpp:112 > + return jsString(exec, asSymbol(argument)->descriptiveString()); Nit: This can be jsNontrivialString, which can be used for Strings guaranteed to be 2 or more characters long, and this is guaranteed to have "Symbol()". Comment on attachment 250171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250171&action=review >> Source/JavaScriptCore/runtime/StringConstructor.cpp:112 >> + return jsString(exec, asSymbol(argument)->descriptiveString()); > > Nit: This can be jsNontrivialString, which can be used for Strings guaranteed to be 2 or more characters long, and this is guaranteed to have "Symbol()". Thank you! I've changed it. Created attachment 250182 [details]
Patch
Comment on attachment 250182 [details]
Patch
r=me
Comment on attachment 250182 [details]
Patch
Thank you for your review :D
Comment on attachment 250182 [details] Patch Clearing flags on attachment: 250182 Committed r182433: <http://trac.webkit.org/changeset/182433> All reviewed patches have been landed. Closing bug. |