[WK2] API::Array::copy() should move the resulting Vector<> of copies into the Array::create() call

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[WK2] API::Array::copy() should move the resulting Vector<> of copies into the Array::create() call

[Zan Dobersek]

Created attachment 250149 [details]
Patch

[Zan Dobersek]

Created attachment 250151 [details]
Patch

[Zan Dobersek]

Created attachment 250152 [details]
Patch

[Darin Adler]

Comment on attachment 250152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250152&action=review

> Source/WebKit2/Shared/API/APIArray.cpp:81
> +Array::Array(Vector<RefPtr<Object>>&& elements)

Seems like this function should be inlined.

> Source/WebKit2/Shared/API/APIArray.h:55
> +    static PassRefPtr<Array> create(Vector<RefPtr<Object>>&& elements);

I don’t think the name “elements” here adds anything.

> Source/WebKit2/Shared/API/APIArray.h:88
> +    explicit Array(Vector<RefPtr<Object>>&& elements);

I don’t think the name “elements” here adds anything.

[Darin Adler]

Comment on attachment 250152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250152&action=review

> Source/WebKit2/Shared/API/APIArray.h:54
>      static PassRefPtr<Array> create();

The return value of these functions should be changed to Ref<Array>.

[Zan Dobersek]

Comment on attachment 250152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250152&action=review

>> Source/WebKit2/Shared/API/APIArray.h:54
>>      static PassRefPtr<Array> create();
> 
> The return value of these functions should be changed to Ref<Array>.

That would make sense, but it's a bigger task since a lot of callers already operate on a PassRefPtr<> or are leaking or accessing the stored object through a pointer. Something for a separate bug.

[Zan Dobersek]

Created attachment 250198 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 250198 [details]
Patch for landing

Clearing flags on attachment: 250198

Committed r182388: <http://trac.webkit.org/changeset/182388>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.