Bug 143341 – InjectedBundleNodeHandle::renderedImage() needs to be exposed from the Cocoa WebAPI layer

• Component: WebKit2
• Status: RESOLVED FIXED

[Said Abou-Hallawa]

A given node in the web page can render itself to an NSImage or UIImage. This can be useful for the UI process to draw complex static html elements (e.g. table, SVG etc) without having to create a WKView for the drawing. All it needs is to create a background WebProcess, load a local web page, get the node of a specific item and draw it to a bitmap.

[Said Abou-Hallawa]

Created attachment 250004 [details]
Patch

[Darin Adler]

Comment on attachment 250004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250004&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:46
> +#if TARGET_OS_IPHONE
> +- (UIImage *)renderedImage:(WKSnapshotOptions)options;
> +#else
> +- (NSImage *)renderedImage:(WKSnapshotOptions)options;
> +#endif

I think we need new availability annotation when we add a new method.

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:74
> +    return [[UIImage alloc] initWithCGImage:image->bitmap()->makeCGImage().get()];

This is missing an autorelease.

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:85
> +    return [[NSImage alloc] initWithCGImage:image->bitmap()->makeCGImage().get() size:NSZeroSize];

This is missing an autorelease.

[Anders Carlsson]

(In reply to comment #2)
> Comment on attachment 250004 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250004&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:46
> > +#if TARGET_OS_IPHONE
> > +- (UIImage *)renderedImage:(WKSnapshotOptions)options;
> > +#else
> > +- (NSImage *)renderedImage:(WKSnapshotOptions)options;
> > +#endif
> 
> I think we need new availability annotation when we add a new method.
> 

Yes. I also think we should call this renderedImageWithOptions:

[Said Abou-Hallawa]

Created attachment 250091 [details]
Patch

[Said Abou-Hallawa]

(In reply to comment #2)
> Comment on attachment 250004 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250004&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:46
> > +#if TARGET_OS_IPHONE
> > +- (UIImage *)renderedImage:(WKSnapshotOptions)options;
> > +#else
> > +- (NSImage *)renderedImage:(WKSnapshotOptions)options;
> > +#endif
> 
> I think we need new availability annotation when we add a new method.
> 

Done. I was not aware of the Cocoa availability annotation.

> > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:74
> > +    return [[UIImage alloc] initWithCGImage:image->bitmap()->makeCGImage().get()];
> 
> This is missing an autorelease.
> 

Done.

> > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:85
> > +    return [[NSImage alloc] initWithCGImage:image->bitmap()->makeCGImage().get() size:NSZeroSize];
> 
> This is missing an autorelease.

Done.

[Said Abou-Hallawa]

(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 250004 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=250004&action=review
> > 
> > > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:46
> > > +#if TARGET_OS_IPHONE
> > > +- (UIImage *)renderedImage:(WKSnapshotOptions)options;
> > > +#else
> > > +- (NSImage *)renderedImage:(WKSnapshotOptions)options;
> > > +#endif
> > 
> > I think we need new availability annotation when we add a new method.
> > 
> 
> Yes. I also think we should call this renderedImageWithOptions:

Done.

[Radar WebKit Bug Importer]

<rdar://problem/20419231>

[WebKit Commit Bot]

Comment on attachment 250091 [details]
Patch

Clearing flags on attachment: 250091

Committed r182327: <http://trac.webkit.org/changeset/182327>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.