Bug 143322

Summary: Media controls should not always auto-hide
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2015-04-01 15:35:29 PDT
Don't hide controls for an <audio> element, when playing to an external device, or for optimized fullscreen.
Attachments
Proposed patch (4.49 KB, patch)
2015-04-01 16:11 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-04-01 15:43:41 PDT
<rdar://problem/20013740>
Radar WebKit Bug Importer
Comment 2 2015-04-01 15:44:24 PDT
<rdar://problem/20391156>
Eric Carlson
Comment 3 2015-04-01 16:11:00 PDT
Created attachment 249951 [details] Proposed patch
Dean Jackson
Comment 4 2015-04-01 16:32:52 PDT
Comment on attachment 249951 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=249951&action=review > Source/WebCore/ChangeLog:15 > + and video.webkitWirelessVideoPlaybackDisabled because know when they change and use them Typo: because *we* know > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:18 > + this.currrentTargetIsWireless = false; Typo: currrent
Eric Carlson
Comment 5 2015-04-01 16:46:05 PDT
(In reply to comment #4) > Comment on attachment 249951 [details] > Proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249951&action=review > > > Source/WebCore/ChangeLog:15 > > + and video.webkitWirelessVideoPlaybackDisabled because know when they change and use them > > Typo: because *we* know > Fixed. > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:18 > > + this.currrentTargetIsWireless = false; > > Typo: currrent > Fixed. Thanks!
Eric Carlson
Comment 6 2015-04-01 16:46:30 PDT
Committed r182262: https://trac.webkit.org/r182262
Note You need to log in before you can comment on or make changes to this bug.