Bug 143322

Summary: Media controls should not always auto-hide
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Description Eric Carlson 2015-04-01 15:35:29 PDT 
Don't hide controls for an <audio> element, when playing to an external device, or for optimized fullscreen.
Comment 1 Eric Carlson 2015-04-01 15:43:41 PDT 
<rdar://problem/20013740>
Comment 2 Radar WebKit Bug Importer 2015-04-01 15:44:24 PDT 
<rdar://problem/20391156>
Comment 3 Eric Carlson 2015-04-01 16:11:00 PDT 
Created attachment 249951 [details]
Proposed patch
Comment 4 Dean Jackson 2015-04-01 16:32:52 PDT 
Comment on attachment 249951 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249951&action=review

> Source/WebCore/ChangeLog:15
> +            and video.webkitWirelessVideoPlaybackDisabled because know when they change and use them

Typo: because *we* know

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:18
> +    this.currrentTargetIsWireless = false;

Typo: currrent
Comment 5 Eric Carlson 2015-04-01 16:46:05 PDT 
(In reply to comment #4)
> Comment on attachment 249951 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249951&action=review
> 
> > Source/WebCore/ChangeLog:15
> > +            and video.webkitWirelessVideoPlaybackDisabled because know when they change and use them
> 
> Typo: because *we* know
> 
Fixed.

> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:18
> > +    this.currrentTargetIsWireless = false;
> 
> Typo: currrent
>
Fixed.

Thanks!
Comment 6 Eric Carlson 2015-04-01 16:46:30 PDT 
Committed r182262: https://trac.webkit.org/r182262