Bug 143316

Summary: Use std::chrono types to represent time in response and cache classes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, japhet, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+
non-llvm build fixes
none
another
none
another
none
another
none
another none

Antti Koivisto
Reported 2015-04-01 13:41:14 PDT
Modernize.
Attachments
patch (40.12 KB, patch)
2015-04-01 14:53 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
non-llvm build fixes (40.18 KB, patch)
2015-04-02 05:13 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (40.18 KB, patch)
2015-04-02 05:32 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (40.20 KB, patch)
2015-04-02 06:20 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (40.27 KB, patch)
2015-04-02 07:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (41.61 KB, patch)
2015-04-02 08:07 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-04-01 14:53:37 PDT
Created attachment 249943 [details] patch
Andreas Kling
Comment 2 2015-04-01 14:59:19 PDT
Comment on attachment 249943 [details] patch r=me
Antti Koivisto
Comment 3 2015-04-02 05:13:39 PDT
Created attachment 249970 [details] non-llvm build fixes
Antti Koivisto
Comment 4 2015-04-02 05:32:22 PDT
Created attachment 249972 [details] another
Antti Koivisto
Comment 5 2015-04-02 06:20:18 PDT
Created attachment 249975 [details] another
Antti Koivisto
Comment 6 2015-04-02 07:25:10 PDT
Created attachment 249977 [details] another
Antti Koivisto
Comment 7 2015-04-02 08:07:59 PDT
Created attachment 249979 [details] another
Antti Koivisto
Comment 8 2015-04-02 08:47:43 PDT
https://trac.webkit.org/r182271
Brent Fulgham
Comment 9 2015-04-02 10:07:14 PDT
This broke four JSC tests on Windows: ** The following JSC stress test failures have been introduced: mozilla-tests.yaml/ecma/Date/15.9.5.8.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.5.8.js.mozilla-baseline mozilla-tests.yaml/ecma/Date/15.9.5.8.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma/Date/15.9.5.8.js.mozilla-llint Can you fix, or should I roll this out?
Antti Koivisto
Comment 10 2015-04-02 11:21:09 PDT
I don't understand how. This patch didn't touch anything on JSC level or below.
Brent Fulgham
Comment 11 2015-04-02 11:27:40 PDT
(In reply to comment #10) > I don't understand how. This patch didn't touch anything on JSC level or > below. It might just be the bot. I'm noticing that one of the two bots is green, while the other is failing.
Antti Koivisto
Comment 12 2015-04-02 11:30:56 PDT
This patch touched WebCore, WebKit and WebKit2 only. Literally no code affected here should end up in jsc.exe.
Anders Carlsson
Comment 13 2015-04-03 10:34:05 PDT
Comment on attachment 249979 [details] another View in context: https://bugs.webkit.org/attachment.cgi?id=249979&action=review > Source/WebCore/platform/network/CacheValidation.cpp:113 > + auto maxAge = response.cacheControlMaxAge(); > + if (maxAge) Can fold this into the if condition. > Source/WebCore/platform/network/HTTPParsers.cpp:243 > + // This assumes system_clock epoch equals Unix epoch which is true for all implementations but unspecified. > + // FIXME: The parsing function should be switched to std::chrono too. Maybe we can use std::chrono::system:clock::to_time_t or something?
Note You need to log in before you can comment on or make changes to this bug.