Bug 143308

Summary: [WinCairo] Link errors, unresolved texture mapper methods.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Description peavo 2015-04-01 09:32:09 PDT 
We need to add some new texture mapper files to the project.
Comment 1 peavo 2015-04-01 09:39:25 PDT 
Created attachment 249925 [details]
Patch
Comment 2 Brent Fulgham 2015-04-01 09:59:11 PDT 
Comment on attachment 249925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249925&action=review

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:1
> +<?xml version="1.0" encoding="utf-8"?>

Looks like we're introducing some UTF byte order markers. This shouldn't be needed for UTF8 formatted files. Could this file be saved as plain text before landing?

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:1
> +<?xml version="1.0" encoding="utf-8"?>

Ditto the BOM here. Just save as plain UTF8.
Comment 3 Alex Christensen 2015-04-01 10:33:06 PDT 
Comment on attachment 249925 [details]
Patch

I'll land this manually.
Comment 4 Alex Christensen 2015-04-01 10:33:47 PDT 
http://trac.webkit.org/changeset/182237
Comment 5 peavo 2015-04-01 10:37:51 PDT 
Reopening to attach new patch.
Comment 6 peavo 2015-04-01 10:37:55 PDT 
Created attachment 249932 [details]
Patch
Comment 7 peavo 2015-04-01 10:39:14 PDT 
(In reply to comment #3)
> Comment on attachment 249925 [details]
> Patch
> 
> I'll land this manually.

Sorry, I didn't see this, thanks for reviewing :)
Comment 8 Alex Christensen 2015-04-01 10:39:54 PDT 
Comment on attachment 249932 [details]
Patch

This is what I landed.
Comment 9 peavo 2015-04-01 10:44:34 PDT 
(In reply to comment #8)
> Comment on attachment 249932 [details]
> Patch
> 
> This is what I landed.

Thanks :)