Bug 143295

Summary: [CMake] Make gtest/CMakeLists.txt more readable
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-03-31 23:52:11 PDT
gtest/CMakeLists.txt has used add_library() and include_directory() directly. It seems to me that it is unsorted use.
Attachments
Patch (2.06 KB, patch)
2015-03-31 23:52 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.06 KB, patch)
2015-03-31 23:54 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-03-31 23:52:56 PDT
Created attachment 249898 [details] Patch
Gyuyoung Kim
Comment 2 2015-03-31 23:54:05 PDT
Created attachment 249899 [details] Patch
WebKit Commit Bot
Comment 3 2015-04-01 03:38:55 PDT
Comment on attachment 249899 [details] Patch Clearing flags on attachment: 249899 Committed r182228: <http://trac.webkit.org/changeset/182228>
WebKit Commit Bot
Comment 4 2015-04-01 03:38:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.