Bug 143295

Summary:

[CMake] Make gtest/CMakeLists.txt more readable

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

Tools / Tests

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Gyuyoung Kim 2015-03-31 23:52:11 PDT

gtest/CMakeLists.txt has used add_library() and include_directory() directly. It seems to me that it is unsorted use.

Comment 1 Gyuyoung Kim 2015-03-31 23:52:56 PDT

Created attachment 249898 [details]
Patch

Comment 2 Gyuyoung Kim 2015-03-31 23:54:05 PDT

Created attachment 249899 [details]
Patch

Comment 3 WebKit Commit Bot 2015-04-01 03:38:55 PDT

Comment on attachment 249899 [details]
Patch

Clearing flags on attachment: 249899

Committed r182228: <http://trac.webkit.org/changeset/182228>

Comment 4 WebKit Commit Bot 2015-04-01 03:38:59 PDT

All reviewed patches have been landed.  Closing bug.