Bug 143289

Summary:

[iOS] Include Add to Reading List link action only where supported

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Define and use HAVE_READING_LIST	thorton: review+

Description mitz 2015-03-31 20:09:55 PDT

<rdar://problem/20365675>

The Add to Reading List link action should only be included in a link’s actions when the functionality is supported.

Comment 1 mitz 2015-03-31 20:52:52 PDT

Created attachment 249883 [details]
Define and use HAVE_READING_LIST

Comment 2 Tim Horton 2015-03-31 21:02:05 PDT

Comment on attachment 249883 [details]
Define and use HAVE_READING_LIST

View in context: https://bugs.webkit.org/attachment.cgi?id=249883&action=review

> Source/WebKit2/config.h:94
> +#define HAVE_READING_LIST 1

Should it not be HAVE_SAFARI_READING_LIST? This is very specifically about the Safari feature, yes?

Comment 3 mitz 2015-03-31 21:03:34 PDT

(In reply to comment #2)
> Comment on attachment 249883 [details]
> Define and use HAVE_READING_LIST
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249883&action=review
> 
> > Source/WebKit2/config.h:94
> > +#define HAVE_READING_LIST 1
> 
> Should it not be HAVE_SAFARI_READING_LIST? This is very specifically about
> the Safari feature, yes?

Going to go with HAVE_SAFARI_SERVICES_FRAMEWORK. Thanks for the review!

Comment 4 mitz 2015-03-31 21:08:20 PDT

Fixed in <http://trac.webkit.org/r182219>.