Bug 143278

Summary: [WK2][iOS] We should prevent NetworkProcess suspension while it has pending SQL transactions
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, barraclough, commit-queue, dbates, ddkilzer, kling, koivisto, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 143249, 143451    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2015-03-31 14:59:58 PDT 
We should prevent NetworkProcess suspension while it has pending SQL transactions, similarly to what we already do for WebProcesses.

Radar: <rdar://problem/20180799>
Comment 1 Chris Dumez 2015-03-31 15:26:33 PDT 
Created attachment 249861 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-31 15:29:35 PDT 
Attachment 249861 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/WebSQLiteDatabaseTracker.cpp:48:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2015-04-02 14:34:19 PDT 
Created attachment 250009 [details]
Patch
Comment 4 Chris Dumez 2015-04-02 14:34:52 PDT 
No longer using Supplements, as per Anders' feedback via IRC.
Comment 5 WebKit Commit Bot 2015-04-02 14:36:42 PDT 
Attachment 250009 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/WebSQLiteDatabaseTracker.cpp:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2015-04-03 09:58:47 PDT 
Comment on attachment 250009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250009&action=review

Do you really need to make the trackers be unique pointers? Can't they be plain members of the WebProcess and NetworkProcess classes?

> Source/WebKit2/WebProcess/WebProcess.h:382
> +    std::unique_ptr<WebSQLiteDatabaseTracker> m_webSQLiteDatabaseManager;

Should be DatabaseTracker, not DatabaseManager.
Comment 7 Chris Dumez 2015-04-03 10:07:05 PDT 
Created attachment 250086 [details]
Patch
Comment 8 WebKit Commit Bot 2015-04-03 10:09:06 PDT 
Attachment 250086 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/WebSQLiteDatabaseTracker.cpp:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2015-04-03 10:55:38 PDT 
Comment on attachment 250086 [details]
Patch

Clearing flags on attachment: 250086

Committed r182323: <http://trac.webkit.org/changeset/182323>
Comment 10 WebKit Commit Bot 2015-04-03 10:55:45 PDT 
All reviewed patches have been landed.  Closing bug.