| Summary: | Lots of time spent querying table cell borders, when there are none. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 249859 [details]
Patch
Comment on attachment 249859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249859&action=review > Source/WebCore/rendering/RenderTableCell.cpp:521 > + return emptyBorder; Return CollapsedBorderValue(BorderValue(), Color(), BCELL); or CollapsedBorderValue::emptyBorder(); > Source/WebCore/rendering/RenderTableCell.cpp:524 > + return emptyBorder; Ditto. > Source/WebCore/rendering/RenderTableSection.cpp:1576 > + HashMap<std::pair<const RenderTableCell*, int>, CollapsedBorderValue>::iterator it = m_cellsCollapsedBorders.find(std::make_pair(&cell, side)); auto! Comment on attachment 249859 [details] Patch Attachment 249859 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5151410542870528 New failing tests: fast/table/border-collapsing/dynamic-border-width-change.html Created attachment 249866 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 249859 [details] Patch Attachment 249859 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4741910644129792 New failing tests: fast/table/border-collapsing/dynamic-border-width-change.html Created attachment 249872 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 249920 [details]
Patch
Comment on attachment 249920 [details] Patch Clearing flags on attachment: 249920 Committed r182235: <http://trac.webkit.org/changeset/182235> All reviewed patches have been landed. Closing bug. |
Created attachment 249854 [details] long-table (collapsed borders) Profiling the attached content, there's lots of time spent fetching cell border properties, when the cells have no borders.