Bug 143277

Summary: Lots of time spent querying table cell borders, when there are none.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
long-table (collapsed borders)
none
Patch
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
Archive of layout-test-results from ews100 for mac-mavericks
none
Patch none

alan
Reported 2015-03-31 14:39:43 PDT
Created attachment 249854 [details] long-table (collapsed borders) Profiling the attached content, there's lots of time spent fetching cell border properties, when the cells have no borders.
Attachments
long-table (collapsed borders) (380 bytes, text/html)
2015-03-31 14:39 PDT, alan 		no flags
Details
Patch (30.17 KB, patch)
2015-03-31 15:15 PDT, alan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (559.66 KB, application/zip)
2015-03-31 16:10 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews100 for mac-mavericks (583.12 KB, application/zip)
2015-03-31 17:53 PDT, Build Bot 		no flags
Details
Patch (32.31 KB, patch)
2015-04-01 07:24 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2015-03-31 14:40:13 PDT
rdar://problem/20200735
alan
Comment 2 2015-03-31 15:15:42 PDT
Created attachment 249859 [details] Patch
Simon Fraser (smfr)
Comment 3 2015-03-31 16:00:18 PDT
Comment on attachment 249859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249859&action=review > Source/WebCore/rendering/RenderTableCell.cpp:521 > + return emptyBorder; Return CollapsedBorderValue(BorderValue(), Color(), BCELL); or CollapsedBorderValue::emptyBorder(); > Source/WebCore/rendering/RenderTableCell.cpp:524 > + return emptyBorder; Ditto. > Source/WebCore/rendering/RenderTableSection.cpp:1576 > + HashMap<std::pair<const RenderTableCell*, int>, CollapsedBorderValue>::iterator it = m_cellsCollapsedBorders.find(std::make_pair(&cell, side)); auto!
Build Bot
Comment 4 2015-03-31 16:10:27 PDT
Comment on attachment 249859 [details] Patch Attachment 249859 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5151410542870528 New failing tests: fast/table/border-collapsing/dynamic-border-width-change.html
Build Bot
Comment 5 2015-03-31 16:10:32 PDT
Created attachment 249866 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 6 2015-03-31 17:53:10 PDT
Comment on attachment 249859 [details] Patch Attachment 249859 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4741910644129792 New failing tests: fast/table/border-collapsing/dynamic-border-width-change.html
Build Bot
Comment 7 2015-03-31 17:53:14 PDT
Created attachment 249872 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
alan
Comment 8 2015-04-01 07:24:08 PDT
Created attachment 249920 [details] Patch
WebKit Commit Bot
Comment 9 2015-04-01 08:57:23 PDT
Comment on attachment 249920 [details] Patch Clearing flags on attachment: 249920 Committed r182235: <http://trac.webkit.org/changeset/182235>
WebKit Commit Bot
Comment 10 2015-04-01 08:57:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.