Cannot remove/customize the "Inspect Element" contextual menu item

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Ian Cely]

The "Inspect Element" menu item gets added to the menu *after* the UIDelegate has been given a chance to customize the menu.  This behavior makes it impossible for client applications to remove or modify this menu item on a per view basis (of course this can be disabled at the application scope via a preference).  In addition the tag for the "Inspect Element" menu item would need to be exposed to the client API.

[Timothy Hatcher]

We should have a way to let the client change this. But we also want the control to force it in there so debugging client apps can still be done, event if the UI delegate removes all menu items blindly.

[Adam Roben (:aroben)]

(In reply to comment #1)
> We should have a way to let the client change this. But we also want the
> control to force it in there so debugging client apps can still be done, event
> if the UI delegate removes all menu items blindly.

Perhaps this is as simple as adding the item to the menu before it is passed up to the UI delegate in Release builds, and adding it afterwards in Debug builds?

[Adam Roben (:aroben)]

Created attachment 15425 [details]
Patch 1/3

Adds Settings::developerMenuExtrasEnabled

[Adam Roben (:aroben)]

Created attachment 15426 [details]
Patch 2/3

Remove ContextMenuClient::shouldIncludeInspectElementItem

[Adam Roben (:aroben)]

Created attachment 15427 [details]
Patch 3/3

Pass the Inspect Element item up to the UI delegate.

[Adam Roben (:aroben)]

I decided to fix a FIXME in ContextMenuController while I was at it (patches 1 and 2). Patch 3 actually fixes the bug.

[Adam Roben (:aroben)]

I suspect these patches cause Safari on Windows to not show the Inspect Element context menu item, though I haven't gotten to test this theory yet. Please don't land these patches yet.

[Adam Roben (:aroben)]

Created attachment 15553 [details]
Patch 1.5/3

Here's a pretty important patch that somehow got left out.

[Adam Roben (:aroben)]

Created attachment 15555 [details]
new Patch 3/3

This patch fixes up Windows so that the Inspect Element item will still show up.

[Adam Roben (:aroben)]

Landed as r24378-r24381