Bug 143237

Summary: [Mac][WK2] Fullscreen animation incorrect when initiated on non-primary monitor
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jer Noble 2015-03-30 14:32:53 PDT 
[Mac][WK2] Fullscreen animation incorrect when initiated on non-primary monitor
Comment 1 Jer Noble 2015-03-30 14:34:39 PDT 
Created attachment 249763 [details]
Patch
Comment 2 Brent Fulgham 2015-04-02 15:34:47 PDT 
Comment on attachment 249763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249763&action=review

No test? :-(

r=me.

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:517
> +    CGAffineTransform resetOriginTransform = CGAffineTransformMakeTranslation(screenFrame.x() - finalFrame.x(), screenFrame.y() - finalFrame.y());

Interesting! I hadn't thought about the case where the screens might be oriented vertically with respect to each other, but of course that's entirely possible.
Comment 3 Jer Noble 2015-04-02 15:39:07 PDT 
(In reply to comment #2)
> Comment on attachment 249763 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249763&action=review
> 
> No test? :-(

I couldn't figure out a way to artificially create a NSScreen and place the NSWindow into it. :(

> r=me.


Thanks!
Comment 4 Jer Noble 2015-04-02 15:41:47 PDT 
rdar://problem/20347504
Comment 5 WebKit Commit Bot 2015-04-02 15:51:30 PDT 
Comment on attachment 249763 [details]
Patch

Clearing flags on attachment: 249763

Committed r182295: <http://trac.webkit.org/changeset/182295>
Comment 6 WebKit Commit Bot 2015-04-02 15:51:33 PDT 
All reviewed patches have been landed.  Closing bug.