Bug 143237 – [Mac][WK2] Fullscreen animation incorrect when initiated on non-primary monitor

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[Mac][WK2] Fullscreen animation incorrect when initiated on non-primary monitor

[Jer Noble]

Created attachment 249763 [details]
Patch

[Brent Fulgham]

Comment on attachment 249763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249763&action=review

No test? :-(

r=me.

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:517
> +    CGAffineTransform resetOriginTransform = CGAffineTransformMakeTranslation(screenFrame.x() - finalFrame.x(), screenFrame.y() - finalFrame.y());

Interesting! I hadn't thought about the case where the screens might be oriented vertically with respect to each other, but of course that's entirely possible.

[Jer Noble]

(In reply to comment #2)
> Comment on attachment 249763 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249763&action=review
> 
> No test? :-(

I couldn't figure out a way to artificially create a NSScreen and place the NSWindow into it. :(

> r=me.


Thanks!

[Jer Noble]

rdar://problem/20347504

[WebKit Commit Bot]

Comment on attachment 249763 [details]
Patch

Clearing flags on attachment: 249763

Committed r182295: <http://trac.webkit.org/changeset/182295>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.