Bug 143229

Summary: [GTK] Layout Test accessibility/aria-toggle-button-with-title.html is failing
Product: WebKit Reporter: Marcos Chavarría Teijeiro (irc: chavaone) <chavarria1991>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, chavarria1991, clopez, commit-queue, dmazzoni, jcraig, jdiggs, mario, ossy, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Marcos Chavarría Teijeiro (irc: chavaone)
Reported 2015-03-30 10:32:09 PDT
The accessibility/aria-toggle-button-with-title.html layout test is failing on GTK+ since r182012 (https://trac.webkit.org/changeset/182012). This revision updates the way a role=button + aria-pressed object should be exposed as AXCheckbox on Mac. The diff is the following: --- /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/accessibility/aria-toggle-button-with-title-expected.txt +++ /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/accessibility/aria-toggle-button-with-title-actual.txt @@ -8,7 +8,7 @@ PASS successfullyParsed is true TEST COMPLETE -Role: AXRole: AXCheckBox +Role: AXRole: AXToggleButton PASS tbutton1.title is 'AXTitle: Toggle button' Role: AXRole: AXButton PASS button.title is 'AXTitle: Button title'
Attachments
Patch (1.71 KB, patch)
2015-03-30 11:10 PDT, Marcos Chavarría Teijeiro (irc: chavaone) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-03-30 10:32:33 PDT
<rdar://problem/20348058>
Radar WebKit Bug Importer
Comment 2 2015-03-30 10:33:23 PDT
<rdar://problem/20348078>
chris fleizach
Comment 3 2015-03-30 11:02:11 PDT
Can you post the whole new actual file that you get. i can post that as the new expected results for GTK
Marcos Chavarría Teijeiro (irc: chavaone)
Comment 4 2015-03-30 11:10:18 PDT
Created attachment 249747 [details] Patch
chris fleizach
Comment 5 2015-03-30 11:11:04 PDT
Comment on attachment 249747 [details] Patch i think this may fail because you've put unreviewed in there, lets' see
Marcos Chavarría Teijeiro (irc: chavaone)
Comment 6 2015-03-30 11:13:56 PDT
(In reply to comment #5) > Comment on attachment 249747 [details] > Patch > > i think this may fail because you've put unreviewed in there, lets' see The thing is that being a gardening patch it doesn't need revision but I forget to add the --no-review flag when I call to upload the patch. Thanks! :)
WebKit Commit Bot
Comment 7 2015-03-30 11:59:11 PDT
Comment on attachment 249747 [details] Patch Clearing flags on attachment: 249747 Committed r182149: <http://trac.webkit.org/changeset/182149>
WebKit Commit Bot
Comment 8 2015-03-30 11:59:15 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 9 2015-04-13 03:23:12 PDT
EFL had similar difference - fixed in http://trac.webkit.org/changeset/182699
Note You need to log in before you can comment on or make changes to this bug.