Summary: | [GTK] DnD icon/widget has odd background | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garnacho <carlosg> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | carlosg, cgarcia, gustavo, pnormand, svillar | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garnacho
2015-03-30 05:26:24 PDT
We can just remove DragIcon entirely, and use simply gtk_drag_set_icon_surface(). Created attachment 249726 [details]
Patch
Comment on attachment 249726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249726&action=review > Source/WebCore/ChangeLog:10 > + Remove DragIcon class since it's no longer needed with GTK+3 and > + the GTK+2 code there is unused. > + It's great that GTK+ improved the API here. Do you mind explaining a bit more here why this is no longer necessary for GTK+3? What changes allow us to work properly with composited window managers without a window? (In reply to comment #3) > Comment on attachment 249726 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249726&action=review > > > Source/WebCore/ChangeLog:10 > > + Remove DragIcon class since it's no longer needed with GTK+3 and > > + the GTK+2 code there is unused. > > + > > It's great that GTK+ improved the API here. Do you mind explaining a bit > more here why this is no longer necessary for GTK+3? What changes allow us > to work properly with composited window managers without a window? GTK+ knows what to do with a cairo surface, I guess we migrated the gtk+2 code to gtk+3 without realizing that using the surface was enough. Comment on attachment 249726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249726&action=review >>> Source/WebCore/ChangeLog:10 >>> + >> >> It's great that GTK+ improved the API here. Do you mind explaining a bit more here why this is no longer necessary for GTK+3? What changes allow us to work properly with composited window managers without a window? > > GTK+ knows what to do with a cairo surface, I guess we migrated the gtk+2 code to gtk+3 without realizing that using the surface was enough. Cool, do you mind just dropping something like that into the ChangeLog? Committed r182175: <http://trac.webkit.org/changeset/182175> |