Bug 143216

Summary: [GStreamer] More GL shared context fixes
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mrobinson, pnormand, vjaquez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch cgarcia: review+

Philippe Normand
Reported 2015-03-30 05:13:42 PDT
The patch from Bug 143049 has various incorrect changes.
Attachments
patch (4.82 KB, patch)
2015-03-30 05:20 PDT, Philippe Normand 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2015-03-30 05:20:36 PDT
Created attachment 249721 [details] patch
Martin Robinson
Comment 2 2015-03-30 08:17:05 PDT
Comment on attachment 249721 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=249721&action=review Looks good apart from the a naming nit: > Source/WebCore/platform/graphics/glx/GLContextGLX.h:52 > + virtual bool isEGLCompliant() const { return false; } A context isn't really "EGL compliant" it's either an EGL context or something else. I recommend just calling this method "isEGLContext."
Philippe Normand
Comment 3 2015-03-30 08:23:23 PDT
Committed r182139: <http://trac.webkit.org/changeset/182139>
Note You need to log in before you can comment on or make changes to this bug.