Bug 143216

Summary:

[GStreamer] More GL shared context fixes

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, mrobinson, pnormand, vjaquez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	cgarcia: review+

Description Philippe Normand 2015-03-30 05:13:42 PDT

The patch from Bug 143049 has various incorrect changes.

Comment 1 Philippe Normand 2015-03-30 05:20:36 PDT

Created attachment 249721 [details]
patch

Comment 2 Martin Robinson 2015-03-30 08:17:05 PDT

Comment on attachment 249721 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249721&action=review

Looks good apart from the a naming nit:

> Source/WebCore/platform/graphics/glx/GLContextGLX.h:52
> +    virtual bool isEGLCompliant() const { return false; }

A context isn't really "EGL compliant" it's either an EGL context or something else. I recommend just calling this method "isEGLContext."

Comment 3 Philippe Normand 2015-03-30 08:23:23 PDT

Committed r182139: <http://trac.webkit.org/changeset/182139>