Bug 143208

Summary:

Web Inspector: Regression: Preview for [[null]] shouldn't be []

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Screenshot of the bug	none
[PATCH] Proposed Fix	none

Description Nikita Vasilyev 2015-03-29 21:32:20 PDT

Created attachment 249709 [details]
Screenshot of the bug

An array of arrays with null(s) displayed as an empty array.

Comment 1 Radar WebKit Bug Importer 2015-03-29 21:32:38 PDT

<rdar://problem/20341961>

Comment 2 Joseph Pecoraro 2015-03-30 11:19:10 PDT

I bet that InjectedScriptSource _isPreviewableObjectInternal just has to handle null!

Comment 3 Joseph Pecoraro 2015-03-30 14:36:16 PDT

Created attachment 249764 [details]
[PATCH] Proposed Fix

Comment 4 Mark Lam 2015-03-30 14:52:51 PDT

Comment on attachment 249764 [details]
[PATCH] Proposed Fix

r=me

Comment 5 WebKit Commit Bot 2015-03-30 15:44:14 PDT

Comment on attachment 249764 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 249764

Committed r182156: <http://trac.webkit.org/changeset/182156>

Comment 6 WebKit Commit Bot 2015-03-30 15:44:19 PDT

All reviewed patches have been landed.  Closing bug.