Bug 143189

Summary: [Win] Allow building JavaScriptCore without Cygwin
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2015-03-28 22:32:44 PDT
[Win] Allow building JavaScriptCore without Cygwin
Attachments
Patch (11.63 KB, patch)
2015-03-28 22:37 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (11.63 KB, patch)
2015-03-29 06:22 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-03-28 22:37:43 PDT
Created attachment 249677 [details] Patch
Myles C. Maxfield
Comment 2 2015-03-29 06:22:58 PDT
Created attachment 249679 [details] Patch
Brent Fulgham
Comment 3 2015-03-29 11:43:24 PDT
Comment on attachment 249679 [details] Patch Nice work!
Myles C. Maxfield
Comment 4 2015-03-29 13:12:37 PDT
Comment on attachment 249679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249679&action=review > Source/JavaScriptCore/UpdateContents.py:45 > +if (not t or comp == comparator): This should be a !=
WebKit Commit Bot
Comment 5 2015-03-29 13:57:06 PDT
Comment on attachment 249679 [details] Patch Clearing flags on attachment: 249679 Committed r182122: <http://trac.webkit.org/changeset/182122>
WebKit Commit Bot
Comment 6 2015-03-29 13:57:11 PDT
All reviewed patches have been landed. Closing bug.
Myles C. Maxfield
Comment 7 2015-03-29 14:56:24 PDT
http://trac.webkit.org/changeset/182123 updates this
Note You need to log in before you can comment on or make changes to this bug.