Bug 143134

Summary: Avoid using hardcoded values for JSValue::Int32Tag, if possible.
Product: WebKit Reporter: peavo
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description peavo 2015-03-27 10:10:48 PDT 
This seems to be a Visual Studio workaround, which probably is not needed anymore.
Comment 1 peavo 2015-03-27 10:12:28 PDT 
Created attachment 249577 [details]
Patch
Comment 2 Geoffrey Garen 2015-03-27 10:35:22 PDT 
Comment on attachment 249577 [details]
Patch

r=me if you can get EWS to build this on Windows, but it doesn't currently.
Comment 3 peavo 2015-03-27 10:39:15 PDT 
(In reply to comment #2)
> Comment on attachment 249577 [details]
> Patch
> 
> r=me if you can get EWS to build this on Windows, but it doesn't currently.

There seems to be a problem applying the patch:

urllib2.URLError: <urlopen error [Errno 8] hostname nor servname provided, or not known>

I'm not sure what that means, I'll try uploading the patch again :)
Comment 4 peavo 2015-03-27 10:41:31 PDT 
Created attachment 249581 [details]
Patch
Comment 5 peavo 2015-03-27 12:25:03 PDT 
Patch is building on Windows now.
Comment 6 Geoffrey Garen 2015-03-27 16:56:16 PDT 
Comment on attachment 249581 [details]
Patch

r=me
Comment 7 peavo 2015-03-27 23:27:33 PDT 
(In reply to comment #6)
> Comment on attachment 249581 [details]
> Patch
> 
> r=me

Thanks :)
Comment 8 WebKit Commit Bot 2015-03-30 13:13:06 PDT 
Comment on attachment 249581 [details]
Patch

Clearing flags on attachment: 249581

Committed r182151: <http://trac.webkit.org/changeset/182151>
Comment 9 WebKit Commit Bot 2015-03-30 13:13:11 PDT 
All reviewed patches have been landed.  Closing bug.