Bug 143134

Summary: Avoid using hardcoded values for JSValue::Int32Tag, if possible.
Product: WebKit Reporter: peavo
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2015-03-27 10:10:48 PDT
This seems to be a Visual Studio workaround, which probably is not needed anymore.
Attachments
Patch (2.46 KB, patch)
2015-03-27 10:12 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2015-03-27 10:41 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2015-03-27 10:12:28 PDT
Created attachment 249577 [details] Patch
Geoffrey Garen
Comment 2 2015-03-27 10:35:22 PDT
Comment on attachment 249577 [details] Patch r=me if you can get EWS to build this on Windows, but it doesn't currently.
peavo
Comment 3 2015-03-27 10:39:15 PDT
(In reply to comment #2) > Comment on attachment 249577 [details] > Patch > > r=me if you can get EWS to build this on Windows, but it doesn't currently. There seems to be a problem applying the patch: urllib2.URLError: <urlopen error [Errno 8] hostname nor servname provided, or not known> I'm not sure what that means, I'll try uploading the patch again :)
peavo
Comment 4 2015-03-27 10:41:31 PDT
Created attachment 249581 [details] Patch
peavo
Comment 5 2015-03-27 12:25:03 PDT
Patch is building on Windows now.
Geoffrey Garen
Comment 6 2015-03-27 16:56:16 PDT
Comment on attachment 249581 [details] Patch r=me
peavo
Comment 7 2015-03-27 23:27:33 PDT
(In reply to comment #6) > Comment on attachment 249581 [details] > Patch > > r=me Thanks :)
WebKit Commit Bot
Comment 8 2015-03-30 13:13:06 PDT
Comment on attachment 249581 [details] Patch Clearing flags on attachment: 249581 Committed r182151: <http://trac.webkit.org/changeset/182151>
WebKit Commit Bot
Comment 9 2015-03-30 13:13:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.