Bug 143129

Summary:

Web Inspector: Add Setter Icon for ObjectTreeView

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	timothy: review+
[IMAGE] What it looks like	none

Joseph Pecoraro

Reported 2015-03-27 00:55:48 PDT

* SUMMARY Add Setter Icon for ObjectTreeView. Instead of using a readonly lock indicating there is no setter. Use an icon that shows the property has a setter. This allows us to more easily display an icon for getter / setter state, and handle the "only setter" state gracefully.

Attachments
[PATCH] Proposed Fix (9.77 KB, patch) 2015-03-27 11:38 PDT, Joseph Pecoraro	timothy: review+	Details Formatted Diff Diff
[IMAGE] What it looks like (128.96 KB, image/png) 2015-03-27 11:39 PDT, Joseph Pecoraro	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-03-27 00:56:30 PDT

<rdar://problem/20323321>

Joseph Pecoraro

Comment 2 2015-03-27 11:38:41 PDT

Created attachment 249589 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 3 2015-03-27 11:39:07 PDT

Created attachment 249590 [details] [IMAGE] What it looks like

Joseph Pecoraro

Comment 4 2015-03-27 19:57:58 PDT

http://trac.webkit.org/changeset/182099

Note You need to log in before you can comment on or make changes to this bug.