Summary: | Web Inspector: Convert more misc View classes to ES6 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||
Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 142891 | ||||||||
Attachments: |
|
Description
Timothy Hatcher
2015-03-26 23:38:48 PDT
Created attachment 249555 [details]
Patch
Created attachment 249556 [details]
Patch (Ignore Space)
Comment on attachment 249556 [details] Patch (Ignore Space) View in context: https://bugs.webkit.org/attachment.cgi?id=249556&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.js:280 > +WebInspector.DashboardContainerView.AdvanceDirection = { > + Forward: Symbol("dashboard-container-view-advance-direction-forward"), > + Backward: Symbol("dashboard-container-view-advance-direction-backward"), > + None: Symbol("dashboard-container-view-advance-direction-none") > +}; > + Nice, moving to Symbol! > Source/WebInspectorUI/UserInterface/Views/DashboardView.js:43 > + static create(representedObject) Yay! > Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:106 > Object.defineProperty(item, "text", > { > - set: function(newText) > + set(newText) So I think I told mattbaker the other day that I don't like this in Object.defineProperty. Since this is really about creating a set property with a function handler, not a method. But having thought more about this, the syntax is pretty cool, cause its the setter syntax inside the descriptor. I could go either way here. > Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js:-84 > -WebInspector.ObjectTreeView.Mode = { > - Properties: Symbol("object-tree-properties"), > - API: Symbol("object-tree-api"), > -}; You will have conflicts with this file. Comment on attachment 249555 [details] Patch https://trac.webkit.org/r182055 |