Bug 143093

Summary:

webkit-patch build-and-test should have an option to iterate over new tests

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Tools / Tests

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, bfulgham, commit-queue, glenn, mcatanzaro, ossy, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

143135

Bug Blocks:

Attachments:

Description	Flags
Patch	none
WIP	none
WIP2	none
Patch	none
Rebasing	none
Patch for landing	none

youenn fablet

Reported 2015-03-26 04:35:15 PDT

As part of enabling limited EWS bots to check new tests, webkit-patch should have the ability to run new tests and report results. This could be done by adding an option to webkit-patch build-and-test to iterate a number of times on new tests and make a report in case of failures.

Attachments
Patch (4.24 KB, patch) 2015-03-26 04:40 PDT, youenn fablet	no flags	Details Formatted Diff Diff
WIP (6.09 KB, patch) 2015-03-27 11:00 PDT, youenn fablet	no flags	Details Formatted Diff Diff
WIP2 (12.39 KB, patch) 2015-03-30 11:12 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (16.20 KB, patch) 2015-03-31 02:41 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Rebasing (17.29 KB, patch) 2016-01-07 06:57 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (17.26 KB, patch) 2016-01-07 23:35 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2015-03-26 04:40:34 PDT

Created attachment 249485 [details] Patch

youenn fablet

Comment 2 2015-03-27 11:00:29 PDT

Created attachment 249585 [details] WIP

youenn fablet

Comment 3 2015-03-27 11:02:14 PDT

(In reply to comment #2) > Created attachment 249585 [details] > WIP Another try after 143090. Plan is to add a unit test for the new_or_modified_potential_tests function. Any feedback appreciated before doing that extra step.

youenn fablet

Comment 4 2015-03-30 11:12:51 PDT

Created attachment 249749 [details] WIP2

youenn fablet

Comment 5 2015-03-31 02:41:47 PDT

Created attachment 249811 [details] Patch

youenn fablet

Comment 6 2016-01-07 06:57:43 PST

Created attachment 268450 [details] Rebasing

youenn fablet

Comment 7 2016-01-07 07:02:20 PST

(In reply to comment #6) > Created attachment 268450 [details] > Rebasing Introduced option (iterate_on_new_tests) may allow gtk/efl/win EWS bots to check new/modified tests at a hopefully small cost. This option may also be useful in general to check for test flakiness.

Michael Catanzaro

Comment 8 2016-01-07 07:56:09 PST

Comment on attachment 268450 [details] Rebasing View in context: https://bugs.webkit.org/attachment.cgi?id=268450&action=review > Tools/ChangeLog:10 > + Computationf of new or modified tests is doen by LayoutTestFinder.find_touched_tests Computationf -> Computation doen -> done

youenn fablet

Comment 9 2016-01-07 23:35:06 PST

Created attachment 268531 [details] Patch for landing

youenn fablet

Comment 10 2016-01-07 23:39:23 PST

Thanks for the review. > > Tools/ChangeLog:10 > > + Computationf of new or modified tests is doen by LayoutTestFinder.find_touched_tests > > Computationf -> Computation > > doen -> done Doen... hum done ;)

WebKit Commit Bot

Comment 11 2016-01-08 00:37:05 PST

Comment on attachment 268531 [details] Patch for landing Clearing flags on attachment: 268531 Committed r194761: <http://trac.webkit.org/changeset/194761>

WebKit Commit Bot

Comment 12 2016-01-08 00:37:11 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.