Bug 143069

Summary: Update prepare-ChangeLog to work with ES6 Class syntax
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, rniwa, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix
joepeck: commit-queue-
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-03-25 20:06:29 PDT
* SUMMARY Update prepare-ChangeLog to work with ES6 Class syntax. Currently it doesn't understand method syntax, so any modifications to Web Inspector files with class syntax produces nothing.
Attachments
[PATCH] Proposed Fix (10.32 KB, patch)
2015-03-25 20:07 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (13.65 KB, patch)
2015-03-25 20:21 PDT, Joseph Pecoraro 		joepeck: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (13.60 KB, patch)
2015-03-25 20:37 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-03-25 20:07:15 PDT
Created attachment 249465 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2015-03-25 20:08:37 PDT
Comment on attachment 249465 [details] [PATCH] Proposed Fix I just realized there are tests. Let me add some quick tests.
Joseph Pecoraro
Comment 3 2015-03-25 20:21:17 PDT
Created attachment 249468 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 4 2015-03-25 20:26:57 PDT
Comment on attachment 249468 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=249468&action=review > Tools/Scripts/prepare-ChangeLog:1393 > + $currentMethod =~ s/\.{2,}/\./g; # Removes consecutive periods. I have a feeling this line is not needed, insect later when this is pop'd it'll do this. So cq- and I can fix locally if that is the case.
Joseph Pecoraro
Comment 5 2015-03-25 20:37:04 PDT
Created attachment 249469 [details] [PATCH] Proposed Fix Nope, that caused issue. But I still tweaked things just a bit to remove duplicated work.
WebKit Commit Bot
Comment 6 2015-03-25 21:38:19 PDT
Comment on attachment 249469 [details] [PATCH] Proposed Fix Clearing flags on attachment: 249469 Committed r181996: <http://trac.webkit.org/changeset/181996>
WebKit Commit Bot
Comment 7 2015-03-25 21:38:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.