| Summary: | Update prepare-ChangeLog to work with ES6 Class syntax | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
| Component: | Tools / Tests | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, dbates, rniwa, timothy | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Joseph Pecoraro
2015-03-25 20:06:29 PDT
Created attachment 249465 [details]
[PATCH] Proposed Fix
Comment on attachment 249465 [details]
[PATCH] Proposed Fix
I just realized there are tests. Let me add some quick tests.
Created attachment 249468 [details]
[PATCH] Proposed Fix
Comment on attachment 249468 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=249468&action=review > Tools/Scripts/prepare-ChangeLog:1393 > + $currentMethod =~ s/\.{2,}/\./g; # Removes consecutive periods. I have a feeling this line is not needed, insect later when this is pop'd it'll do this. So cq- and I can fix locally if that is the case. Created attachment 249469 [details]
[PATCH] Proposed Fix
Nope, that caused issue. But I still tweaked things just a bit to remove duplicated work.
Comment on attachment 249469 [details] [PATCH] Proposed Fix Clearing flags on attachment: 249469 Committed r181996: <http://trac.webkit.org/changeset/181996> All reviewed patches have been landed. Closing bug. |