Bug 14305

Summary:

Web Inspector marks local files with server-side compression tip (Patch Included)

Product:

WebKit

Reporter:

Richard Connamacher <richardconnamacher>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

OS X 10.4

Attachments:

Description	Flags
Patch to inspector/Resource.js	timothy: review+
ChangeLog	timothy: review+

Richard Connamacher

Reported 2007-06-21 23:46:55 PDT

Web Inspector provides server-side compression advice to files that do not originate from a server. (For example, inspecting Web Inspector determines that its own code could be sped up using zlib?) I've included my fix, a patch to inspector/Resource.js to add one extra check (to verify non-local origin) before marking a resource with this tip.

Attachments
Patch to inspector/Resource.js (652 bytes, patch) 2007-06-21 23:48 PDT, Richard Connamacher	timothy: review+	Details Formatted Diff Diff
ChangeLog (252 bytes, text/plain) 2007-06-22 00:06 PDT, Richard Connamacher	timothy: review+	Details
View All Add attachment proposed patch, testcase, etc.

Richard Connamacher

Comment 1 2007-06-21 23:48:19 PDT

Created attachment 15176 [details] Patch to inspector/Resource.js

Adam Roben (:aroben)

Comment 2 2007-06-21 23:54:21 PDT

Comment on attachment 15176 [details] Patch to inspector/Resource.js The patch looks good, but it needs a ChangeLog entry as well. You can use WebKitTools/Scripts/prepare-ChangeLog to get you started.

Richard Connamacher

Comment 3 2007-06-22 00:06:03 PDT

Created attachment 15177 [details] ChangeLog Please note I don't currently have an svn checkout.

Timothy Hatcher

Comment 4 2007-06-22 09:58:45 PDT

Comment on attachment 15177 [details] ChangeLog Please include the ChangeLog in your patch next time.

Timothy Hatcher

Comment 5 2007-06-22 09:59:50 PDT

Landed in r23738.

Note You need to log in before you can comment on or make changes to this bug.