Bug 143048

Summary:

[Streams API] Error storage should be moved from source to stream/reader

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, calvaris, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Improving assert. Enabled case of creating ReadableStream with an empty source	none

Description youenn fablet 2015-03-25 07:07:13 PDT

Access to error goes through Reader now.
It is thus more appropriate to move the error storage to the stream and not the source.

Comment 1 youenn fablet 2015-03-25 07:18:07 PDT

Created attachment 249401 [details]
Patch

Comment 2 youenn fablet 2015-03-27 07:44:45 PDT

Created attachment 249567 [details]
Improving assert. Enabled case of creating ReadableStream with an empty source

Comment 3 Benjamin Poulain 2015-03-27 16:03:53 PDT

Comment on attachment 249567 [details]
Improving assert. Enabled case of creating ReadableStream with an empty source

View in context: https://bugs.webkit.org/attachment.cgi?id=249567&action=review

Ok

> Source/WebCore/bindings/js/ReadableStreamJSSource.cpp:73
> +        ASSERT(exec->argument(0).isObject());

Let's use ASSERT_WITH_MESSAGE to better explain why should the first argument must exist and be an object at this point.

Comment 4 WebKit Commit Bot 2015-03-30 08:24:11 PDT

Comment on attachment 249567 [details]
Improving assert. Enabled case of creating ReadableStream with an empty source

Clearing flags on attachment: 249567

Committed r182140: <http://trac.webkit.org/changeset/182140>

Comment 5 WebKit Commit Bot 2015-03-30 08:24:15 PDT

All reviewed patches have been landed.  Closing bug.