Summary: | New map and set modification tests in r181922 fails | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Critical | CC: | bfulgham, buildbot, cgarcia, fpizlo, ggaren, mark.lam, msaboff, oliver, ossy, rniwa, ysuzuki | ||||||||||
Priority: | P1 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 142696 | ||||||||||||
Attachments: |
|
Description
Mark Lam
2015-03-24 19:12:32 PDT
I'm now preparing a patch to fix it simply. https://bugs.webkit.org/show_bug.cgi?id=142696 Created attachment 249377 [details]
Patch
Comment on attachment 249377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249377&action=review > Source/JavaScriptCore/ChangeLog:53 > + when adjusting m_index. This is a little bit ugly, but it eliminates heap stored MapDataPatch. Alternative fix is iterating twice. 1st: Calculating newEnd and packing to destination by destination[newEnd] = entry; 2nd: Iterating in reverse order and decrementing m_index. Comment on attachment 249377 [details] Patch Attachment 249377 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6471842135015424 New failing tests: fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html Created attachment 249381 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
I don't think that it's Windows only, they fail on Mac too. The EWS failure is unrelated. Created attachment 249389 [details]
Patch
Just updated the title of ChangeLog since this is not limited in Windows environment
Oops! This will teach me to land a patch and then go home :(. Comment on attachment 249389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249389&action=review > Source/JavaScriptCore/runtime/MapData.h:73 > + if (m_oldIndexUsedDuringPacking <= index) I think we can accomplish this without an extra pass to save our old index. I'll post another tweak to do this. Created attachment 249417 [details]
Patch
Committed r181968: <http://trac.webkit.org/changeset/181968> Comment on attachment 249389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249389&action=review >> Source/JavaScriptCore/runtime/MapData.h:73 >> + if (m_oldIndexUsedDuringPacking <= index) > > I think we can accomplish this without an extra pass to save our old index. I'll post another tweak to do this. Great! Your tweak is very reasonable. Thank you! |