Bug 143014

Summary: [WK2] Responses with 404 HTTP Status Code should be cacheable by default
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://tools.ietf.org/html/rfc7231#section-6.5.4
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-03-24 13:18:38 PDT
Responses with 404 HTTP Status Code should be cacheable by default according to RFC 7231: """ A 404 response is cacheable by default; i.e., unless otherwise indicated by the method definition or explicit cache controls (see Section 4.2.2 of [RFC7234]). """ [1] [1] http://tools.ietf.org/html/rfc7231#section-6.5.4 The new WebKit Network cache does not currently cache these, even if Cache-Control headers allow us to do so.
Attachments
Patch (5.20 KB, patch)
2015-03-24 13:27 PDT, Chris Dumez
no flags
Patch (5.14 KB, patch)
2015-03-24 13:39 PDT, Chris Dumez
no flags
Radar WebKit Bug Importer
Comment 1 2015-03-24 13:19:28 PDT
Chris Dumez
Comment 2 2015-03-24 13:27:05 PDT
Antti Koivisto
Comment 3 2015-03-24 13:35:42 PDT
Comment on attachment 249343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249343&action=review > LayoutTests/http/tests/cache/disk-cache/disk-cache-404-status-code.html:21 > +var testMatrix = > +[ > + [ > + { responseHeaders: {'Status': '404', 'Cache-control': 'max-age=0' } }, > + { responseHeaders: {'Status': '404', 'Cache-control': 'max-age=100' } }, > + ], > + ]; > + > +description("Test that responses with HTTP status code 404 are cacheable"); > + > +var tests = generateTests(testMatrix); > + > +debug("running " + tests.length + " tests"); > +debug(""); > + > +runTests(tests); If you don't need permutations you can just define the tests as simple array and call runTests directly.
Chris Dumez
Comment 4 2015-03-24 13:39:49 PDT
Chris Dumez
Comment 5 2015-03-24 13:43:01 PDT
Comment on attachment 249347 [details] Patch Clearing flags on attachment: 249347 Committed r181904: <http://trac.webkit.org/changeset/181904>
Chris Dumez
Comment 6 2015-03-24 13:43:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.