Bug 14299

Summary: fast/dom/HTMLDocument/frameless-location-bugzilla10837.html test is timing dependent
Product: WebKit Reporter: Matt Perry <mpComplete>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: All   
OS: Windows XP   
Attachments:
Description Flags
patch
none
revised patch sam: review+

Matt Perry
Reported 2007-06-21 16:18:17 PDT
I was able to get this test to fail on the Windows port because the second frame begins loading the data URL before the first frame was done. On the Mac it appears that the second frame doesn't get to load in time, and the render tree is dumped prematurely. I'm going to add a waitUntilDone() call to this test, so it always waits for the second frame to finish loading.
Attachments
patch (10.15 KB, patch)
2007-06-21 16:19 PDT, Matt Perry 		no flags
DetailsFormatted DiffDiff
revised patch (10.19 KB, patch)
2007-06-21 17:11 PDT, Matt Perry 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Perry
Comment 1 2007-06-21 16:19:14 PDT
Created attachment 15169 [details] patch
mitz
Comment 2 2007-06-21 16:46:21 PDT
Comment on attachment 15169 [details] patch + f.location = 'data:text/html,%3Cbody onload=%22layoutTestController.notifyDone();%22%3Efoo%3C/body%3E'; I think it would be nicer if you checked for layoutTestController there too.
Matt Perry
Comment 3 2007-06-21 17:11:08 PDT
Created attachment 15171 [details] revised patch Same as first patch, but with mitz's suggestion.
Sam Weinig
Comment 4 2007-06-24 22:04:29 PDT
Comment on attachment 15171 [details] revised patch Looks good.
Mark Rowe (bdash)
Comment 5 2007-06-25 03:27:39 PDT
Landed in r23760.
Note You need to log in before you can comment on or make changes to this bug.