Bug 142976

Summary: REGRESSION (r179820): accessibility/textarea-selected-text-range.html is flaky
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: AccessibilityAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=143315
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2015-03-23 13:04:42 PDT
accessibility/textarea-selected-text-range.html flakily fails on Mac bots (WK1 and WK2, Mavericks and Yosemite, debug and release). @@ -1,4 +1,4 @@ -PASS textArea.selectedTextRange is '{4, 0}' +FAIL textArea.selectedTextRange should be {4, 0}. Was {0, 0}. PASS textArea.selectedTextRange is '{8, 2}' PASS textArea.selectedTextRange is '{25, 0}' PASS successfullyParsed is true
Attachments
proposed fix (8.23 KB, patch)
2015-03-31 22:28 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-03-23 13:05:06 PDT
<rdar://problem/20263270>
Alexey Proskuryakov
Comment 2 2015-03-23 13:06:57 PDT
Marked as flaky in <http://trac.webkit.org/r181861>.
Alexey Proskuryakov
Comment 3 2015-03-31 22:25:10 PDT
This is a regression from <http://trac.webkit.org/changeset/179820>. There is a race between a 1 ms delay timer and a dispatch_async - there is no ordering defined for these.
Alexey Proskuryakov
Comment 4 2015-03-31 22:28:06 PDT
Created attachment 249894 [details] proposed fix
chris fleizach
Comment 5 2015-03-31 23:14:47 PDT
Comment on attachment 249894 [details] proposed fix shouldBecomeEquals. that's a great idea. thanks!
WebKit Commit Bot
Comment 6 2015-04-01 00:08:02 PDT
Comment on attachment 249894 [details] proposed fix Clearing flags on attachment: 249894 Committed r182223: <http://trac.webkit.org/changeset/182223>
WebKit Commit Bot
Comment 7 2015-04-01 00:08:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.