Bug 142951

Summary: [iOS] Expose WebPageProxy::setInitialFocus as SPI
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add -[WKWebView(WKPrivate) _becomeFirstResponderWithSelectionMovingForward:completionHandler:] andersca: review+

mitz
Reported 2015-03-22 13:23:09 PDT
Add SPI allowing moving focus into a WKWebView.
Attachments
Add -[WKWebView(WKPrivate) _becomeFirstResponderWithSelectionMovingForward:completionHandler:] (11.80 KB, patch)
2015-03-22 13:38 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2015-03-22 13:38:01 PDT
Created attachment 249206 [details] Add -[WKWebView(WKPrivate) _becomeFirstResponderWithSelectionMovingForward:completionHandler:]
WebKit Commit Bot
Comment 2 2015-03-22 13:39:59 PDT
Attachment 249206 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1796: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1422: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:392: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2015-03-22 14:45:45 PDT
Committed <http://trac.webkit.org/r181836>.
Note You need to log in before you can comment on or make changes to this bug.