Bug 142950

Summary: ~13% of time spent in MarkRoots is unaccounted for in GC phase timings
Product: WebKit Reporter: Mark Hahnenberg <mhahnenb>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenb>
Status: NEW ---    
Severity: Normal CC: ahmad.saleem792, ap, ashvayka, mark.lam, rniwa, ysuzuki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140774    
Attachments:
Description Flags
MarkRoots lots of "Other"
none
Patch ggaren: review+

Description Mark Hahnenberg 2015-03-22 13:08:45 PDT 
While messing around with graphing the time spent in each GC phase, I noticed that more than 13% of the time spent in the marking phase is currently unaccounted for (i.e. there is no active GCTimer for 13% of time spent in marking). There could be some GC pause time optimizations hiding in there, so we should figure out where that time is going.
Comment 1 Mark Hahnenberg 2015-03-22 19:25:44 PDT 
Created attachment 249216 [details]
MarkRoots lots of "Other"

Here's some graph output for the tool I mentioned. This run shows ~12% of "Other". Even though it says there are 9 categories in "Other", if I modify the tool so that those categories aren't included in "Other", it will still be ~12%.
Comment 2 Mark Hahnenberg 2015-03-28 10:16:06 PDT 
Created attachment 249663 [details]
Patch
Comment 3 Geoffrey Garen 2015-03-28 18:10:51 PDT 
Comment on attachment 249663 [details]
Patch

r=me
Comment 4 Ahmad Saleem 2022-10-09 06:23:30 PDT 
I checked via BugID and it seems that this r+ patch didn't landed yet.

Do we need it now? Thanks!