Bug 142926

Summary:

FunctionBodyNode should known where its parameters started

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Description Geoffrey Garen 2015-03-20 15:52:15 PDT

FunctionBodyNode should known where its parameters started

Comment 1 Geoffrey Garen 2015-03-20 15:56:10 PDT

Created attachment 249140 [details]
Patch

Comment 2 WebKit Commit Bot 2015-03-20 15:58:41 PDT

Attachment 249140 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/parser/Nodes.cpp:178:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/parser/Nodes.cpp:179:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/parser/Nodes.cpp:180:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Ryosuke Niwa 2015-03-20 16:33:43 PDT

Comment on attachment 249140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249140&action=review

> Source/JavaScriptCore/parser/Nodes.cpp:174
> +    ParserArena&, const JSTokenLocation& startLocation, 
> +    const JSTokenLocation& endLocation, unsigned startColumn, unsigned endColumn, 
> +    int functionKeywordStart, int functionNameStart, int parametersStart,
> +    bool isInStrictContext, ConstructorKind constructorKind)

These lines need to be indented further by 4 spaces (8 spaces total).

Comment 4 Geoffrey Garen 2015-03-20 16:38:26 PDT

Committed r181818: <http://trac.webkit.org/changeset/181818>