| Summary: | DFG IR should represent the various of effects of put_by_id in a single node | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 142920 | ||
| Bug Blocks: | |||
An alternate approach might be: https://bugs.webkit.org/show_bug.cgi?id=142924 |
Currently put_by_id may turn into a three-node lowering: AllocatePropertyStorage, PutByOffset, PutStructure. This barely works. We should use a single node ("PutByOffsetWithPropertyAllocationTransition", or something with a shorter name) so that code motion of things that GC and exit doesn't have to tiptoe around this.