| Summary: | Web Inspector: gaps between sections of the styles sidebar rules tab confusing, should say "Media: all" | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Wells <jonowells> | ||||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 255330 [details]
Patch
Comment on attachment 255330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255330&action=review > Source/WebInspectorUI/ChangeLog:9 > + (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Now properly adds padding to filtered labels. Should wrap the comment to the next line. > Source/WebInspectorUI/ChangeLog:12 > + (WebInspector.RulesStyleDetailsPanel.prototype.refresh): If a section of CSS rules has no media or ineritance, add a label that says "Media: all" above the section. Typo: inheritance? Should wrap this long line too. Created attachment 255353 [details]
Patch
Comment on attachment 255353 [details] Patch Clearing flags on attachment: 255353 Committed r185845: <http://trac.webkit.org/changeset/185845> All reviewed patches have been landed. Closing bug. |
Created attachment 249132 [details] [SCREENSHOT] Styles sidebar rules tab There are gray gaps between sections in the styles sidebar rules tab when there are media queries in a document. apple.com is a good example to see this in action. Some sections will start with "Media: only screen", etc, for the corresponding query, but other sections will say nothing, Perhaps those should say "Media: all" or "All media." Attached screenshot shows the issue.