Bug 142916 – [WK2] Allow stale content when restoring the browser's session state

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Allow stale content when restoring the browser's session state (restoring all tabs from previous session), e.g.
- Via History > Reopen All windows from previous session on Safari
- Happens on startup for MobileSafari

Radar: <rdar://problem/18769970>

[Chris Dumez]

Created attachment 249129 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/20243493>

[Chris Dumez]

Created attachment 249133 [details]
Patch

[Darin Adler]

Comment on attachment 249133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249133&action=review

> Source/WebKit2/ChangeLog:12
> +        Allow stale content when restoring the browser's session state
> +        (restoring all tabs from previous session), e.g.
> +        - Via History > Reopen All windows from previous session on Safari
> +        - Happens on startup for MobileSafari

A cool idea, but seems a little risky. Might be a mix of new content and really old content depending on what’s in the cache.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:-2100
> -                return goToBackForwardItem(item, AllowStaleContent::No);

You could have made this a 1-line patch and then later removed this argument once we are sure it’s the right thing!

[WebKit Commit Bot]

Comment on attachment 249133 [details]
Patch

Clearing flags on attachment: 249133

Committed r181815: <http://trac.webkit.org/changeset/181815>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.