Bug 142909 – [EFL][GTK] WebKit2's generate-forwarding-headers.pl should fail if clashing headers found

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

Long time ago clashing headers caused race conditon, which is 
absolutely undesirable. Build system must be deterministic.

And then http://trac.webkit.org/changeset/79544 introduced a workaround 
for handling clashing headers, because Qt added a clashing header. But 
now there is no Qt and no clashing header and I don't think if we should 
prefer one from clashing headers, but exit with error to force the renaming.

Its sideeffect will be to be able to fix bug142907 easier. :)

[Csaba Osztrogonác]

Created attachment 249110 [details]
Patch

[Csaba Osztrogonác]

Created attachment 249483 [details]
Patch

updataed to ToT

[Csaba Osztrogonác]

Comment on attachment 249483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249483&action=review

> Source/WebKit2/Scripts/generate-forwarding-headers.pl:101
> +        # If we found more headers with the same name, exit immediately.
> +        my @headers = grep($_ =~ "/$headerName\$", @frameworkHeaders);
> +        if (@headers != 1) {
> +            print("ERROR: Can't create $headerName forwarding header, because there are more headers with the same name:\n");
> +            foreach (@headers) { print " - $_\n" };
> +            die();

Ping for review?

It is so simple patch, only this part changed, the other 
parts are only whitespace changes due to indentation.

[WebKit Commit Bot]

Comment on attachment 249483 [details]
Patch

Clearing flags on attachment: 249483

Committed r182138: <http://trac.webkit.org/changeset/182138>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.