Bug 142907

Summary: [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gyuyoung.kim, mrobinson, ossy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 142909    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-03-20 05:22:11 PDT
generate-forwarding-headers.pl is to generate forwarding headers for "Mac framework style" includes in WebKit2, WTR and WebKitTestAPI. (for example: #include <WebKit/baz.h> when foo.h is in WebKit2/foo/bar/baz.h) Now it runs 10 times on EFL, but 3 run would be enough - one for each target. But to do it, generate-forwarding-headers.pl should be refactored a little bit. Patch is coming soon.
Attachments
Patch (9.57 KB, patch)
2015-03-20 06:24 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-03-20 05:25:15 PDT
While only slightly related to this bug, I'm interested what people think about the verbosity of this script. Does anyone else find all the "[Creating forwarding header for ...]" messages during build either terribly helpful or completely unnecessary? I myself would like to remove the message, or at least make it optional in case the script needs to be debugged.
Csaba Osztrogonác
Comment 2 2015-03-20 05:35:20 PDT
(In reply to comment #1) > While only slightly related to this bug, I'm interested what people think > about the verbosity of this script. > > Does anyone else find all the "[Creating forwarding header for ...]" > messages during build either terribly helpful or completely unnecessary? I > myself would like to remove the message, or at least make it optional in > case the script needs to be debugged. I agree, we can disable it by default, here you are: bug142908
Csaba Osztrogonác
Comment 3 2015-03-20 06:24:06 PDT
Created attachment 249111 [details] Patch finished, but it depends on bug142907 because of changed to array
Csaba Osztrogonác
Comment 4 2015-03-20 06:26:32 PDT
(In reply to comment #3) > Created attachment 249111 [details] > Patch > > finished, but it depends on bug142907 because of changed to array typo: changed $platform to array (but I should have escaped $platform in bash :) )
Csaba Osztrogonác
Comment 5 2015-04-03 03:34:52 PDT
Comment on attachment 249111 [details] Patch Ooops, missed to set r? after bug142909 was fixed and EWS passed.
Carlos Garcia Campos
Comment 6 2015-04-09 00:23:22 PDT
Comment on attachment 249111 [details] Patch Ok, let's try this way. Thanks!
WebKit Commit Bot
Comment 7 2015-04-09 01:12:48 PDT
Comment on attachment 249111 [details] Patch Clearing flags on attachment: 249111 Committed r182595: <http://trac.webkit.org/changeset/182595>
WebKit Commit Bot
Comment 8 2015-04-09 01:12:53 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 9 2015-04-09 04:53:33 PDT
and a typo fixed in http://trac.webkit.org/changeset/182598
Note You need to log in before you can comment on or make changes to this bug.