Bug 14289 – Spinneret builds but won't run.

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Jake]

Even though spinneret now builds with the new win32 code it doesn't run because CoreGraphics isn't getting initialized.

[Jake]

Created attachment 15166 [details]
Contains a fix for this bug.

This patch contains changes to Spinneret.cpp that initializes CoreGraphics. It uses the same method (InitializeCoreGraphics) as DumpRenderTree.

[Adam Roben (:aroben)]

Comment on attachment 15166 [details]
Contains a fix for this bug.

I think instead of using LoadLibrary Spinneret should link against CoreGraphics[_debug].lib so it can just call InitializeCoreGraphics directly. This is what DRT does.

[Adam Roben (:aroben)]

(In reply to comment #2)
> (From update of attachment 15166 [details] [edit])
> I think instead of using LoadLibrary Spinneret should link against
> CoreGraphics[_debug].lib so it can just call InitializeCoreGraphics directly.
> This is what DRT does.

Sorry, just CoreGraphics.lib.

[Jake]

Well, I thought about that, but Spinneret uses only the COM interfaces and I'd like to keep it that way. In reality the call to InitializeCoreGraphics should be moved under the COM interfaces, in to WebKit. This is just a quick fix so that Spinneret will work, and w/o having additional link requirements imposed upon it.

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 15166 [details] [edit] [edit])
> > I think instead of using LoadLibrary Spinneret should link against
> > CoreGraphics[_debug].lib so it can just call InitializeCoreGraphics directly.
> > This is what DRT does.
> 
> Sorry, just CoreGraphics.lib.
>