Bug 14287

Summary:

Don't add a null icon to the icon cache for every page without a favicon

Product:

WebKit

Reporter:

Adam Treat <manyoso>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

staikos

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
Fix for this bug	ggaren: review-

Adam Treat

Reported 2007-06-21 11:44:12 PDT

Currently, the iconloader adds an icon to the cache whenever it hits an error page and it also adds a null icon to the cache for every page that doesn't have a favicon. This makes sure to add an icon to the cache only when actual data exists.

Attachments
Fix for this bug (1.39 KB, patch) 2007-06-21 11:45 PDT, Adam Treat	ggaren: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Treat

Comment 1 2007-06-21 11:45:03 PDT

Created attachment 15165 [details] Fix for this bug

Oliver Hunt

Comment 2 2007-06-21 11:55:18 PDT

Comment on attachment 15165 [details] Fix for this bug Ok, this looks good, but i strongly suspect this will cause a perf regression. I suspect we cache null favicons to prevent us repeatedly trying to fetch a favicon from servers that don't have one.

Geoffrey Garen

Comment 3 2007-06-21 12:00:18 PDT

Comment on attachment 15165 [details] Fix for this bug We track these icons to avoid redundant network requests, which hurt performance.

Brady Eidson

Comment 4 2007-06-21 13:20:55 PDT

This behavior is intentional. We track pages that don't have icons to prevent pinging the page for its icon every time. There's expiration-date behavior here so we would re-request the icon once a day or once a week (I forget which), and we also re-request the icon if the user manually reloads the page. Closing as invalid...

Note You need to log in before you can comment on or make changes to this bug.